Repository navigation
feat(benchmark): run identity suites with explicit providers - #714
Merged
Merged
Conversation
Add an explicit provider command for caller-owned cohort and prior-thread fixtures, with all-pair preflight and retained replay artifacts. Keep provider access isolated from live reviews and record partial failures, usage, and cost estimates without credentials.
Separate the reusable choice client from report identity prompts and make model, endpoint, authentication, limits and prices explicit caller settings. Preserve private replay artifacts and distinguish unknown costs from known zero.
Exercise TypeSafe authentication and resolved model handling with the shared identity adapter. Add small synthetic cohort and prior-thread fixtures for provider smoke checks.
This was referenced Nov 7, 2026
zzwong
commented
Nov 9, 2026
This was referenced Nov 9, 2026
Add Decisions request and answer handling to provider-driven identity experiments while preserving refusals, cache uncertainty and original evidence. Include shared provider execution, selected-store credentials and replay contract enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run offline report-identity fixtures through
cr benchmark run identity.yml, using either--provider NAME --model IDor--candidate NAME. Strict suite configuration names the adapter, endpoint and credential-store reference; a saved candidate binds a model to its provider. Selection is explicit, with no inferred provider, model or paid fallback.Support System One-compatible services, including Jev, OpenAI Decisions and Cloudflare Clef through shared prompts, pair preparation, budgets, receipts and deterministic replay. Clef requires explicit acknowledgement that complete-context consumption is unverified. Adapter clients contain no identity prompt or price policy. Existing PR-review suites keep their format and behavior.
The shared executor, selected-store credential resolution and complete serialized-fixture preflight are included from #715, #716, #718 and #719. Retained original records and resolved provider/model provenance are hash-bound; missing prices or uncertain cache usage keep cost unknown. Unshipped model-specific commands are replaced without aliases. This is an offline experiment path; live reviews and posting are unchanged.
Validation