Repository navigation
refactor(benchmark): share identity experiment execution - #718
Merged
zzwong merged 2 commits intoNov 10, 2026
Merged
Conversation
zzwong
commented
Nov 9, 2026
Resolve provider credentials through the selected secret store and preserve complete replayable inputs. Cover command credential selection, fixture size boundaries and unknown cache-write costs.
zzwong
marked this pull request as ready for review
November 10, 2026 14:34
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share report-identity preparation, sequential inference, receipts and private artifact publication between offline benchmarks and the separate diagnostic observer. System One request construction is shared; OpenAI Decisions and Clef retain their provider-specific adapters.
Direct and saved-candidate runs resolve keys through the configured credential store and provider-specific key mapping. Output reservation and complete-fixture size checks happen before credential lookup or provider calls. Retained inputs preserve complete report text and replayable request encoding.
Includes the credential and replay contract fixes. Post-review observer wiring remains in the separate shadow feature; this change does not alter live review verdicts or posting.
Validation
make checkpassed, including tidy, formatting, lint, the full test suite and build.