Repository navigation
Speak the standard SkirRPC protocol - #2
Merged
Merged
Conversation
Requests are sent as MethodName:number::denseJson and responses decoded as dense JSON, matching upstream Skir clients, so the client works against any SkirRPC server. Removes the codec abstraction, SkirClientCodecs and the SKIR_CLIENT_CODEC setting.
Cross-repository changes can then be tested together before merging.
This was referenced Nov 9, 2026
Merged
Feature-branch checkouts otherwise report dev-<branch>, which no version constraint matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client now sends requests the way upstream Skir clients do: a
POSTwith bodyMethodName:number::denseJson, and decodes the dense JSON response. It works against any SkirRPC server, not onlyphp-skir/server.Breaking (0.2.0):
SkirClientCodec,SkirClientCodecs,DenseJsonCodec,StandardJsonCodec,Base64DenseJsonCodec) and theSKIR_CLIENT_CODEC/skir-client.codecsetting.SkirClienttakes only a base URL and endpoint.SkirRpcRequestexposesdescriptorandrequestas public readonly properties, which is handy forMockClient::assertSent().Docs:
docs/configuration-and-codecs.mdbecomesdocs/configuration.md; Boost guidance updated.CI now checks out same-named branches of sibling repos when they exist, so cross-repo changes are tested together.
Pairs with php-skir/server#2 and php-skir/runtime#2 (same branch name).