Skip to content

Speak the standard SkirRPC protocol - #2

Merged
happyDemon merged 3 commits into
mainfrom
skir-rpc-protocol
Nov 9, 2026
Merged

happyDemon merged 3 commits into
mainfrom
skir-rpc-protocol

Conversation

@happyDemon

Copy link
Copy Markdown
Member

The client now sends requests the way upstream Skir clients do: a POST with body MethodName:number::denseJson, and decodes the dense JSON response. It works against any SkirRPC server, not only php-skir/server.

Breaking (0.2.0):

  • Removes the codec abstraction (SkirClientCodec, SkirClientCodecs, DenseJsonCodec, StandardJsonCodec, Base64DenseJsonCodec) and the SKIR_CLIENT_CODEC / skir-client.codec setting.
  • SkirClient takes only a base URL and endpoint.
  • SkirRpcRequest exposes descriptor and request as public readonly properties, which is handy for MockClient::assertSent().

Docs: docs/configuration-and-codecs.md becomes docs/configuration.md; Boost guidance updated.

CI now checks out same-named branches of sibling repos when they exist, so cross-repo changes are tested together.

Pairs with php-skir/server#2 and php-skir/runtime#2 (same branch name).

Requests are sent as MethodName:number::denseJson and responses decoded as
dense JSON, matching upstream Skir clients, so the client works against any
SkirRPC server. Removes the codec abstraction, SkirClientCodecs and the
SKIR_CLIENT_CODEC setting.
Cross-repository changes can then be tested together before merging.
Feature-branch checkouts otherwise report dev-<branch>, which no version
constraint matches.
@happyDemon
happyDemon merged commit 392e018 into main Nov 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant