Repository navigation
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
|
@serhiy-storchaka Could you review this? Thanks! |
|
This PR is stale because it has been open for 90 days with no activity. |
terryjreedy
left a comment
There was a problem hiding this comment.
I agree with items 3 - 7 but not with 1 and 2. As I said in #67407 (comment)), I want to keep the column and move 'Close' to the bottom. This matches Notepad++.
Add ':' after 'Options'.
Add a co-authorship line (or lines), just above the hidden comment in the opening message, for whosoever's code (if any) you copied from.
Co-authored-by: Human Name <emailname@site> (I asked other devs "When adding a co-authorship line for a mannequin, omit or fake it unknown@python.org or ???" and will report answer.
Pending a code and live review, I would merge with these changes. I added a issue comment about further changes on a followup issue. If you can easily improve item 1, size and alignment, with size and padding changes, and want to do so, go ahead. But I don't want to here review more than that.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase We will deal with the sanitizer failures if they remain after retest triggered by a new commit. |
|
Sorry about that! I ran into some issues while trying to sync this old PR and accidentally included upstream changes in the PR. I'm trying to fix it, or I might need to create a new PR. Really sorry for bothering everyone |
|
The problem was likely the force-push. It sometimes has this result, which is one of the reasons we discourage it. |
The issue addressed by this PR is almost 10 years old. #67407 proposed some changes, but there are still some issues, such as the shortening of "regular expression" to "regex" not being accepted. The main issue addressed by this PR has not changed; most of it is about the proposed changes, and modifications have been made according to Terry's suggestions #67407 (comment)
[ Find ]to[ Find Next ](terry)Modernize the IDLE Find/Replace/Find in Files dialogs #67407 (comment))