Skip to content

gh-67407: Improve IDLE Find, Replace and Find in Files dialogs - #122394

Closed
Wulian233 wants to merge 9 commits into
python:mainfrom
Wulian233:idledialog
Closed

Wulian233 wants to merge 9 commits into
python:mainfrom
Wulian233:idledialog

Conversation

@Wulian233

@Wulian233 Wulian233 commented Jul 29, 2024 •

Copy link
Copy Markdown
Contributor

The issue addressed by this PR is almost 10 years old. #67407 proposed some changes, but there are still some issues, such as the shortening of "regular expression" to "regex" not being accepted. The main issue addressed by this PR has not changed; most of it is about the proposed changes, and modifications have been made according to Terry's suggestions #67407 (comment)

idle

  • Got rid of the "close" button, since it is redundant.
  • Moved the buttons below the text fields, to make better use of screen real estate.
  • Shorten the titles by getting rid of the "Dialog" part.
  • Renamed "Search" title to "Find" to match the menu item.
  • Added slightly more padding.
  • Removed the "Replace+Find" and made "Replace" have this functionality. (all modern editors use Replace to mean "Replace and Find")
  • Change replace dialog button [ Find ] to [ Find Next ] (terry)Modernize the IDLE Find/Replace/Find in Files dialogs #67407 (comment)
    )

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 13, 2026
@Wulian233

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Could you review this? Thanks!

@serhiy-storchaka
serhiy-storchaka self-requested a review July 8, 2026 13:12
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 14, 2026
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 14, 2026
@terryjreedy terryjreedy added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 21, 2026

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with items 3 - 7 but not with 1 and 2. As I said in #67407 (comment)), I want to keep the column and move 'Close' to the bottom. This matches Notepad++.

Add ':' after 'Options'.

Add a co-authorship line (or lines), just above the hidden comment in the opening message, for whosoever's code (if any) you copied from.
Co-authored-by: Human Name <emailname@site> (I asked other devs "When adding a co-authorship line for a mannequin, omit or fake it unknown@python.org or ???" and will report answer.

Pending a code and live review, I would merge with these changes. I added a issue comment about further changes on a followup issue. If you can easily improve item 1, size and alignment, with size and padding changes, and want to do so, go ahead. But I don't want to here review more than that.

@bedevere-app

bedevere-app Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

We will deal with the sanitizer failures if they remain after retest triggered by a new commit.

@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 21, 2026
Co-authored-by: Al Sweigart <asweigart@gmail.com>
@Wulian233

Copy link
Copy Markdown
Contributor Author

Sorry about that! I ran into some issues while trying to sync this old PR and accidentally included upstream changes in the PR. I'm trying to fix it, or I might need to create a new PR. Really sorry for bothering everyone

@terryjreedy

Copy link
Copy Markdown
Member

The problem was likely the force-push. It sometimes has this result, which is one of the reasons we discourage it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants